Correct LicenceEntity changes

In creating `LicenceEntityRole` we spotted that the ID is not automatically generated. When we checked back on `LegacyEntity` we found the same. So, this change corrects what we've just done in [Add LicenceEntityModel](#690).
DEFRA · Jan 27, 2024 · db868d4 · db868d4
1 parent fca4315
commit db868d4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/db/migrations/legacy/20240127115605_create-crm-entity.js b/db/migrations/legacy/20240127115605_create-crm-entity.js
@@ -8,7 +8,7 @@ exports.up = function (knex) {
     .withSchema('crm')
     .createTable(tableName, (table) => {
       // Primary Key
-      table.uuid('entity_id').primary().defaultTo(knex.raw('gen_random_uuid()'))
+      table.uuid('entity_id').primary()
 
       // Data
       table.string('entity_nm').notNullable()

diff --git a/test/models/licence-entity.model.test.js b/test/models/licence-entity.model.test.js
@@ -14,7 +14,7 @@ const LicenceEntityHelper = require('../support/helpers/licence-entity.helper.js
 // Thing under test
 const LicenceEntityModel = require('../../app/models/licence-entity.model.js')
 
-describe('Licence Role model', () => {
+describe('Licence Entity model', () => {
   let testRecord
 
   beforeEach(async () => {

diff --git a/test/support/helpers/licence-entity.helper.js b/test/support/helpers/licence-entity.helper.js
@@ -4,13 +4,15 @@
  * @module LicenceEntityHelper
  */
 
+const { generateUUID } = require('../../../app/lib/general.lib.js')
 const LicenceEntityModel = require('../../../app/models/licence-entity.model.js')
 
 /**
  * Add a new licence entity
  *
  * If no `data` is provided, default values will be used. These are
  *
+ * - `id` - [random UUID]
  * - `name` - Grace Hopper
  * - `type` - individual
  *
@@ -36,6 +38,7 @@ async function add (data = {}) {
  */
 function defaults (data = {}) {
   const defaults = {
+    id: generateUUID(),
     name: 'Grace Hopper',
     type: 'Licence Holder'
   }