Skip to content

Commit

Permalink
Refactor supplementary test code
Browse files Browse the repository at this point in the history
https://eaflood.atlassian.net/browse/WATER-3854

We are about to [Update "create bill run" endpoint to create a bill run](#56). Currently, everything is happening in the controller whereas our convention is to do everything in a service and keep our controllers ['skinny'](https://blog.makersacademy.com/forget-fat-models-its-time-for-skinny-controllers-and-skinny-models-a9b84ec481b7).

So, we need a service, something like `SupplementaryService`. But oh no! It already exists.

This change is about refactoring the code currently in `SupplementaryService` to a more explicit testing version so we can free up the namespace. While we're at it, we also rename our `/test` path to `/qa` because everyone is getting confused when they come across a `test/` folder in the repo!
  • Loading branch information
Cruikshanks committed Dec 20, 2022
1 parent a95dc35 commit 9a3e02e
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 9a3e02e

Please sign in to comment.