Changes needed to get the unit tests passing again

DEFRA · Dec 19, 2023 · 8ba86ff · 8ba86ff
1 parent 50e4e61
commit 8ba86ff
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/test/lib/request.lib.test.js b/test/lib/request.lib.test.js
@@ -15,7 +15,7 @@ const requestConfig = require('../../config/request.config.js')
 // Thing under test
 const RequestLib = require('../../app/lib/request.lib.js')
 
-describe.only('RequestLib', () => {
+describe('RequestLib', () => {
   const testDomain = 'http://example.com'
   const shortBackoffLimitRetryOptions = {
     ...RequestLib.defaultOptions.retry,
@@ -141,7 +141,9 @@ describe.only('RequestLib', () => {
           Sinon.replace(requestConfig, 'timeout', 50)
         })
 
-        describe('and all retries fail', () => {
+        // Because of the fake delay in this test, Lab will timeout (by default tests have 2 seconds to finish). So, we
+        // have to override the timeout for this specific test to all it to complete
+        describe('and all retries fail', { timeout: 5000 }, () => {
           beforeEach(async () => {
             Nock(testDomain)
               .get(() => true)
@@ -348,7 +350,9 @@ describe.only('RequestLib', () => {
           Sinon.replace(requestConfig, 'timeout', 50)
         })
 
-        describe('and all retries fail', () => {
+        // Because of the fake delay in this test, Lab will timeout (by default tests have 2 seconds to finish). So, we
+        // have to override the timeout for this specific test to all it to complete
+        describe('and all retries fail', { timeout: 5000 }, () => {
           beforeEach(async () => {
             Nock(testDomain)
               .patch(() => true)
@@ -555,7 +559,9 @@ describe.only('RequestLib', () => {
           Sinon.replace(requestConfig, 'timeout', 50)
         })
 
-        describe('and all retries fail', () => {
+        // Because of the fake delay in this test, Lab will timeout (by default tests have 2 seconds to finish). So, we
+        // have to override the timeout for this specific test to all it to complete
+        describe('and all retries fail', { timeout: 5000 }, () => {
           beforeEach(async () => {
             Nock(testDomain)
               .post(() => true)