Skip to content

Commit

Permalink
Move SendTransactions to root with refactoring
Browse files Browse the repository at this point in the history
https://eaflood.atlassian.net/browse/WATER-4365

> For context this came out of us working on re-implementing the SROC annual bill run using what we've learnt and components from our supplementary billing engine.

As part of looking at re-implementing the SROC annual billing engine in this project our spike (WATER-4348 ) confirmed we'd need to reuse some of the services currently sitting in `app/services/bill-runs/supplementary`.

We moved most of these in [Move shared billing services to bill-runs root](#720) but left `app/services/bill-runs/supplementary/send-transactions.service.js` out even though we also need to reuse it.

When working on the spike we found there is some tidy up we can do in the service. We also spotted we were passing in `BillLicence` purely to set the `billLicenceId`. We now feel this should be done elsewhere.

So, we're doing those changes here as they are a little more involved than simply moving the service.
  • Loading branch information
Cruikshanks committed Feb 20, 2024
1 parent b3b814d commit 8598109
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 8598109

Please sign in to comment.