Skip to content

Commit

Permalink
Update two-part tariff review pages to add Cypress data test attribut…
Browse files Browse the repository at this point in the history
…es (#1139)

https://eaflood.atlassian.net/browse/WATER-4450

During the work to change the licence view page from the legacy code to the new code, there was a change to any links that directed a user to view a licence. Since the licence review page for our two-part tariff work has 3 links to view the licence, this page was altered in those changes. When those changes were made the data-test attributes for the 3 links were removed and subsequently the acceptance tests began failing.
This PR is to add those back in.
  • Loading branch information
Beckyrose200 authored Jun 25, 2024
1 parent 8a0c37d commit 3dbbdf4
Showing 1 changed file with 13 additions and 7 deletions.
20 changes: 13 additions & 7 deletions app/views/bill-runs/review-licence.njk
Original file line number Diff line number Diff line change
Expand Up @@ -46,40 +46,46 @@
<li class="govuk-summary-list__actions-list-item">
<a
class="govuk-link govuk-!-font-weight-bold govuk-link--no-visited-state govuk-link--no-underline"
href="/system/licences/{{ licence.licenceId }}/summary">
href="/system/licences/{{ licence.licenceId }}/summary"
data-test="summary-link">
Summary
</a>
</li>
<li class="govuk-summary-list__actions-list-item">
<a
class="govuk-link govuk-!-font-weight-bold govuk-link--no-visited-state govuk-link--no-underline"
href="/system/licences/{{ licence.licenceId }}/returns">
href="/system/licences/{{ licence.licenceId }}/returns"
data-test="returns-link">
Returns
</a>
</li>
<li class="govuk-summary-list__actions-list-item">
<a
class="govuk-link govuk-!-font-weight-bold govuk-link--no-visited-state govuk-link--no-underline"
href="/system/licences/{{ licence.licenceId }}/set-up">
href="/system/licences/{{ licence.licenceId }}/set-up"
data-test="charge-information-link">
Charge information
</a>
</li>
{% else %}
<li class="govuk-summary-list__actions-list-item"><a
class="govuk-link govuk-!-font-weight-bold govuk-link--no-visited-state govuk-link--no-underline"
href="/licences/{{ licence.licenceId }}#summary">
href="/licences/{{ licence.licenceId }}#summary"
data-test="summary-link">
Summary
</a>
</li>
<li class="govuk-summary-list__actions-list-item"><a
class="govuk-link govuk-!-font-weight-bold govuk-link--no-visited-state govuk-link--no-underline"
href="/licences/{{ licence.licenceId }}#returns">
href="/licences/{{ licence.licenceId }}#returns"
data-test="returns-link">
Returns
</a>
</li>
<li class="govuk-summary-list__actions-list-item"><a
class="govuk-link govuk-!-font-weight-bold govuk-link--no-visited-state govuk-link--no-underline"
href="/licences/{{ licence.licenceId }}#charge">
href="/licences/{{ licence.licenceId }}#charge"
data-test="charge-information-link">
Charge information
</a>
</li>
Expand Down Expand Up @@ -420,7 +426,7 @@

<div class="govuk-!-margin-top-6">
<span class="govuk-body govuk-!-font-weight-regular" data-test="charge-version-{{ chargeVersionIndex }}-charge-reference-{{chargeReferenceIndex}}-element-count-{{ chargeElementIndex }}">{{chargeElement.elementNumber}}</span>
<span class="float-right">
<span class="float-right" data-test="charge-version-{{ chargeVersionIndex }}-charge-reference-{{chargeReferenceIndex}}-element-status-{{ chargeElementIndex }}">
{{ statusTag(chargeElement.elementStatus) }}
</span>
<h3 class="govuk-heading-s govuk-!-margin-bottom-1" data-test="charge-version-{{ chargeVersionIndex }}-charge-reference-{{chargeReferenceIndex}}-element-description-{{ chargeElementIndex }}">{{chargeElement.elementDescription}}
Expand Down

0 comments on commit 3dbbdf4

Please sign in to comment.