Skip to content

Commit

Permalink
Update FetchChargeVersions to use SROC flag
Browse files Browse the repository at this point in the history
https://eaflood.atlassian.net/browse/WATER-3948

We have an issue that the current `include_in_supplementary_billing` flag was added at a time there was only 1 charge scheme. A licence gets flagged irrespective of whether the change relates to PRESROC or SROC.

Where that has impacted us is when sending a billing batch. When it gets sent it clears the flag for _all_ licences included. But if we cancel one, for example, the PRESROC bill run, and send the SROC one we lose which licences still need to be processed on the PRESROC one.

[Our solution](DEFRA/water-abstraction-service#2077) is to add a new `include_in_sroc_supplementary_billing` flag to the `licences` table and only set it to 'true' when an SROC charge version is approved. With this in place our `FetchChargeVersionsService` needs to be altered to look at that field instead of the old one to identify charge versions to consider for billing.
  • Loading branch information
Cruikshanks committed Mar 27, 2023
1 parent d793976 commit 39eddb8
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 39eddb8

Please sign in to comment.