Add insert on conflict to seeders (#1219)

* Add insert on conflict to seeders

As we move to using seeders for tests we can look to add functionality to allow us to seed the actually database.

This change adds ON CONLICT resoultion based on unique constraints that are not the primary id's. This will allow the seeders to seed data and not affect existing data.

This change is part of ongoing work to with the import service and test improvements to allow us to move to parallel test runs.

db/migrations/legacy/20221108007028_water-licence-version-purpose-condition-types.js

@@ -20,6 +20,8 @@ exports.up = function (knex) {
       // Legacy timestamps
       table.timestamp('date_created', { useTz: false }).notNullable().defaultTo(knex.fn.now())
       table.timestamp('date_updated', { useTz: false }).notNullable().defaultTo(knex.fn.now())
+
+      table.unique(['code', 'subcode'], 'uidx_code_subcode')
     })
 }
 

test/support/seeders/licence-version-purpose-condition-types.seeder.js

@@ -17,7 +17,13 @@ const keys = ['id', 'code', 'subcode', 'description', 'subcodeDescription', 'dis
 async function seed () {
   await db.raw(`
     INSERT INTO  public.licence_version_purpose_condition_types (id, code, subcode, description, subcode_description, display_title, created_at, updated_at)
-      VALUES ${buildSeedValueString(keys, data)};
+      VALUES ${buildSeedValueString(keys, data)}
+    ON CONFLICT (code, subcode)
+    DO UPDATE SET
+    description = excluded.description,
+    subcode_description = excluded.subcode_description,
+    display_title = excluded.display_title,
+    updated_at = now()
   `
   )
 }

test/support/seeders/primary-purpose.seeder.js

@@ -17,7 +17,11 @@ const keys = ['id', 'legacyId', 'description', 'createdAt', 'updatedAt']
 async function seed () {
   await db.raw(`
     INSERT INTO  public.primary_purposes (id, legacy_id, description, created_at, updated_at)
-      VALUES ${buildSeedValueString(keys, data)};
+      VALUES ${buildSeedValueString(keys, data)}
+    ON CONFLICT (legacy_id)
+    DO UPDATE SET
+    description = excluded.description,
+    updated_at = now()
   `
   )
 }

test/support/seeders/purposes.seeder.js

@@ -17,7 +17,13 @@ const keys = ['id', 'legacyId', 'description', 'lossFactor', 'twoPartTariff', 'c
 async function seed () {
   await db.raw(`
     INSERT INTO  public.purposes (id, legacy_id, description, loss_factor, two_part_tariff, created_at, updated_at)
-      VALUES ${buildSeedValueString(keys, data)};
+      VALUES ${buildSeedValueString(keys, data)}
+    ON CONFLICT (legacy_id)
+    DO UPDATE SET
+    description = excluded.description,
+    loss_factor = excluded.loss_factor,
+    two_part_tariff = excluded.two_part_tariff,
+    updated_at = now()
   `
   )
 }

test/support/seeders/secondary-purpose.seeder.js

@@ -17,7 +17,11 @@ const keys = ['id', 'legacyId', 'description', 'createdAt', 'updatedAt']
 async function seed () {
   await db.raw(`
     INSERT INTO  public.secondary_purposes (id, legacy_id, description, created_at, updated_at)
-      VALUES ${buildSeedValueString(keys, data)};
+      VALUES ${buildSeedValueString(keys, data)}
+    ON CONFLICT (legacy_id)
+    DO UPDATE SET
+    description = excluded.description,
+    updated_at = now()
   `
   )
 }