Fix type defaults on the water notes table #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4566 During the creation of the licence history page, we noticed we are missing the model and helper for the notes table. This is being referenced when extracting charge versions for a licence and any relating notes created. This is being worked on in the [Create notes table model, helper and view](DEFRA/water-abstraction-system#1240) in water-abstraction-system repo. While working on the change we realised the notes table has fields that are unused: - `licence_id` - is never populated - `type` - is always set to 'charge-version' - `type_id` - is set to the charge version's id and is not needed to link the two together We do not these fields included in the view for the notes table that we will add to [water-abstraction-system](https://github.com/DEFRA/water-abstraction-system). However, `type` and `type_id` are set as not-nullable. This change defaults type to 'charge-version' and`type_id` will remove the constraint.
rvsiyad
added
the
housekeeping
Cruikshanks
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4566
During the creation of the licence history page, we noticed we were missing the model and helper for the notes table. This is being referenced when extracting charge versions for a licence and any relating notes created. This is being worked on in the Create notes table model, helper, and view in the water-abstraction-system repo.
While working on the change we realised the notes table has fields that are unused:
licence_id- is never populatedtype- is always set to 'charge-version'type_id- is set to the charge version's id and is not needed to link the two togetherWe do not these fields included in the view for the notes table that we will add to water-abstraction-system. However,
typeandtype_idare set as not-nullable. This change defaults type to 'charge-version' andtype_idwill remove the constraint.