Fix remove bill licence supplementary flagging #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4415 We spotted that our new billing views had dropped the button that allows a user to remove a licence from a bill run (only applies to `READY`` bill runs and bills with more than one licence). We put the button back in and even gave the confirmation page a refresh. But we're not in a position to migrate the actual work yet. So, our page like the old one pings the same legacy endpoint as [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui). Our QA team being as conscientious as always double-checked all aspects, following up on the message that both the old and new pages display stating the licence will be flagged for the next supplementary bill run. Only they have found it sometimes doesn't, or only flags it for the old (PRESROC) charge scheme. We need to be looking at the scheme of the bill run we are removing the licence from and then setting the appropriate supplementary billing flag on the licence.
It was calling the function but not passing in the scheme param. This means it kept using the default arg of `alcs`. Fortunately we have the scheme to hand so can pass it in and let `flagForSupplementaryBilling()` do its stuff.
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
Beckyrose200 and
rvsiyad
Cruikshanks
added a commit
to DEFRA/water-abstraction-system
that referenced
this pull request
Mar 19, 2024
https://eaflood.atlassian.net/browse/WATER-4416 We'd recently spotted that the new billing views we'd developed had dropped a 'Remove licence' button. So, we used that opportunity to [Migrate confirm remove licence from bill run page](#828) and [added the button back in](#824). But then our conscientious QA team started testing it and found it didn't do what it claimed to do. That was flag the removed licence for the next supplementary bill run. We display the same message on the confirm remove bill from bill run so now doubtful they tested that as well with the same result. We've [fixed the remove licence issue](DEFRA/water-abstraction-service#2464). But whilst we fix the legacy code for remove bill run this is a great opportunity to also migrate the confirm remove bill from bill run page.
Cruikshanks
added a commit
to DEFRA/water-abstraction-system
that referenced
this pull request
Mar 20, 2024
https://eaflood.atlassian.net/browse/WATER-4416 We'd recently spotted that the new billing views we'd developed had dropped a 'Remove licence' button. So, we used that opportunity to [Migrate confirm remove licence from bill run page](#828) and [added the button back in](#824). But then our conscientious QA team started testing it and found it didn't do what it claimed to do. That was to flag the removed licence for the next supplementary bill run. We display the same message on the confirm remove bill from bill run so now doubtful they tested that as well with the same result. We've [fixed the remove licence issue](DEFRA/water-abstraction-service#2464). But whilst we fix the legacy code for remove bill run this is a great opportunity to also migrate the confirm remove bill from bill run page. Not only is it one less thing in the legacy code but we can also update the view to be consistent with others we've done like - [Migrate confirm remove licence from bill run page](#828) - [Migrate view errored bill run page](#785) - [Migrate view empty bill run page](#783) - [Add cancel bill run page](#780)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4415
We spotted that our new billing views had dropped the button that allows a user to remove a licence from a bill run (only applies to `READY`` bill runs and bills with more than one licence).
We put the button back in and even gave the confirmation page a refresh. But we're not in a position to migrate the actual work yet. So, our page like the old one pings the same legacy endpoint as water-abstraction-ui.
Our QA team being as conscientious as always double-checked all aspects, following up on the message that both the old and new pages display stating the licence will be flagged for the next supplementary bill run.
They have found it only flags it for the old (PRESROC) charge scheme.
We need to be looking at the scheme of the bill run we are removing the licence from and then set the appropriate supplementary billing flag on the licence.