Add migration to unflag non-SROC licences #2150
Merged
+59
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we made the change [Migration to flag sroc supp. billing invoices](#2088) we just assumed that all licences by now would have an SROC charge version. In testing we have found there are licences - with only PRESROC charge versions - with no charge versions at all! This means our premise that the flags would be cleared once a bill run has been ran is invalid. For some licences they will never be cleared! 🤦 So, we're adding this migration to clean up our mess. It will unflag any licence flagged for SROC supplementary that doesn't have at least 1 charge version with a start date >= 2022-04-01.
Cruikshanks
added
the
housekeeping
Cruikshanks
added a commit
that referenced
this pull request
May 22, 2023
https://eaflood.atlassian.net/browse/WATER-3995 We added a migration recently to [unflag non-SROC licences](#2150). At the same time we learnt that the [water-import-service](https://github.com/DEFRA/water-abstraction-import) was setting `include_in_supplementary_billing` for any licence where a change in the revoked, lapsed or expired date was noticed. It wasn't checking if the licence has only SROC charge versions, or if it had none. This causes the same problem our previous migration was fixing; licences get flagged for PRESROC supplementary billing but there is no way to clear it because they'll never be processed when billing runs. We've [updated the water-abstraction-import](DEFRA/water-abstraction-import#631) to be more intelligent in how it flags licences. This migration will remove the flag from those licences that should never have been flagged in the first place.
Cruikshanks
added a commit
that referenced
this pull request
May 22, 2023
https://eaflood.atlassian.net/browse/WATER-3995 We added a migration recently to [unflag non-SROC licences](#2150). At the same time, we learnt that the [water-import-service](https://github.com/DEFRA/water-abstraction-import) was setting `include_in_supplementary_billing` for any licence where a change in the revoked, lapsed or expired date was noticed. It wasn't checking if the licence has only SROC charge versions, or if it had none. This causes the same problem our previous migration was fixing; licences get flagged for PRESROC supplementary billing but there is no way to clear it because they'll never be processed when billing runs. We've [updated the water-abstraction-import](DEFRA/water-abstraction-import#631) to be more intelligent in how it flags licences. This migration will remove the flag from those licences that should never have been flagged in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we made the change Migration to flag sroc supp. billing invoices we just assumed that all licences by now would have an SROC charge version. In testing, we have found there are licences
This means our premise that the flags would be cleared once a bill run has been run is invalid. Some licences will never be cleared! 🤦
So, we're adding this migration to clean up our mess. It will unflag any licence flagged for SROC supplementary that doesn't have at least 1 charge version with a start date >= 2022-04-01.