Add missing return version end dates during import #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4514 We've been extending and amending the import of return versions from NALD to WRLS as part of our work to switch from NALD to WRLS for managing them. We've spotted that some of the return versions we are importing are missing end dates. |Return Version ID|Licence ID|Version number|Start date|End date |Status | |-----------------|----------|--------------|----------|----------|-------| |RV1 |LV1 |100 |1984-10-22|2008-03-31|Current| |RV2 |LV1 |101 |2008-04-01|2009-03-31|Current| |RV3 |LV1 |102 |2009-04-01| |Current| |RV4 |LV1 |103 |2023-04-01| |Current| We expect the 'latest' return version to have no end date because it reflects what is the return requirements that should be used for anything in the future. But in this example `RV3` should have an end date. This is an error on the part of NALD we should correct during the import.
Cruikshanks
added a commit
that referenced
this pull request
Aug 30, 2024
https://eaflood.atlassian.net/browse/WATER-4514 > Part of the work to migrate return version management from NALD to WRLS In [Add missing return version end dates during import](#954) we added a query to the import that will fill in the missing end dates for return versions imported from NALD. WRLS requires a 'complete' history in the versions (no gaps) which isn't enforced in NALD. It works great! The problem is it didn't consider returns versions added directly to WRLS. In fairness, it didn't need to. The intent is that the import would be killed on the day WRLS took over return version management. In practice though, the team and our users are trying to conduct testing of the new functionality, but then seeing what they've added messed with when the import runs during the night. This change updates the query to ignore stuff added directly in WRLS, and just look at the records imported from NALD to stop things getting messed up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4514
We've been extending and amending the import of return versions from NALD to WRLS as part of our work to switch from NALD to WRLS for managing them.
We've spotted that some of the return versions we are importing are missing end dates.
We expect the 'latest' return version to have no end date because it reflects the return requirements that should be used for anything in the future. But in this example,
RV3should have an end date (2023-03-31). This is an error on the part of NALD we should correct during the import.