Update log and errbit notifiers #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working on [Move ChargeVersionsMetadataImport out of NALD](#661) we encountered an error. That was expected; we were mid-implementation. What we didn't expect was - the lack of detail in the log - that attempting to view the error in Errbit caused an error Suffice to say, we realised our notifier implementation was wrong. We were passing things incorrectly to both [pino](https://github.com/pinojs/pino) and [errbit](https://github.com/errbit/errbit). [Better handle errors in Notifiers](DEFRA/water-abstraction-system#273) goes into more detail about the issue and what we did to resolve it. That is our main repo and the place we copied the current implementation of `GlobalNotifier` and `BaseNotifier` from. So, we did the original fixes there. This change updates the copies of those notifiers in this repo to include the fixes.
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on Move ChargeVersionsMetadataImport out of NALD we encountered an error. That was expected; we were mid-implementation. What we didn't expect was
Suffice it to say, we realised our notifier implementation was wrong. We were passing things incorrectly to both pino and errbit. Better handle errors in Notifiers goes into more detail about the issue and what we did to resolve it.
That is our main repo and the place we copied the current implementation of
GlobalNotifierandBaseNotifier. So, we did the original fixes there. This change updates the copies of those notifiers in this repo to include the fixes.