Fix proxy config defect #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this is a straightforward fix to how we were passing through configuration options, we decided we don't need to add additional unit tests to our existing rules service tests
So that we don't lose the info on how to set up a local proxy for testing, we add comments to docker-compose.yml and .env.example detailing the process.
Cruikshanks
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/jira/software/projects/CMEA/boards/907?selectedIssue=CMEA-98
As reported by WRLS, the existing way of specifying the proxy doesn't work correctly. This is due to us replacing the previous http request library with
Gotbut not updating the proxy configuration to reflect breaking changes, and this went undiscovered as we don't use a proxy in any of our environments! We therefore resolve this by reworking how proxy configuration is applied.In order to test this locally, add the following lines to
docker-compose.yml:And define the proxy in
.envas follows: