Add error page for HTTP 400 #627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
designer/server/src/views/400.njk
Outdated
Comment on lines
1
to
2
| {% extends 'layouts/page.njk' %} | ||
| {% from "govuk/components/button/macro.njk" import govukButton %} |
There was a problem hiding this comment.
Slowly trying to switch to double quotes everywhere in Nunjucks
Suggested change
| {% extends 'layouts/page.njk' %} | |
| {% from "govuk/components/button/macro.njk" import govukButton %} | |
| {% extends "layouts/page.njk" %} | |
| {% from "govuk/components/button/macro.njk" import govukButton %} |
There was a problem hiding this comment.
Done for a few pages I found
designer/server/src/views/400.njk
Outdated
| {% call appPageBody({ | ||
| heading: pageHeading | ||
| }) %} | ||
| <p class="govuk-body">The service couldn't process your request.</p> |
There was a problem hiding this comment.
What does "process your request" mean to a user?
Watch out for the negative contraction "couldn't" too
Suggested change
| <p class="govuk-body">The service couldn't process your request.</p> | |
| <p class="govuk-body">The service could not process your request.</p> |
There was a problem hiding this comment.
I've put the question to Dan, will look to merge this unless they weigh in and let them improve it later.
|
davidjamesstone
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports 368034 to present a friendly error rather than JSON if the user changes the URL parameters.