Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TGC-476 + TGC-479 page templating yes no question #54

Merged
merged 24 commits into from
Nov 7, 2024
Merged

TGC-476 + TGC-479 page templating yes no question #54

merged 24 commits into from
Nov 7, 2024

Conversation

Andrew-Folga
Copy link
Collaborator

@Andrew-Folga Andrew-Folga commented Nov 6, 2024 •
edited
Loading

This PR introduces following changes:

  • introduces single nunjucks template for all standard pages called page.njk
  • provides implementation for first question (country) with relevant answers and designs
  • tracks user answers
  • add sidebar macros and implements it on the generic page template
  • Improves narrow tests with interaction tests
  • changes library from cheerio back to domjs as cheerio does not support interactions

Note: This PR does not repopulate previous answers when traversing pages back and forth yet.

Screenshot 2024-11-07 at 11 31 21

ScenarioFactory
ScenarioFactory reviewed Nov 6, 2024
View reviewed changes
@Andrew-Folga Andrew-Folga force-pushed the TGC-476-page-templating-yes-no-question branch from e9c6b26 to be57b46 Compare November 6, 2024 17:36
@Andrew-Folga Andrew-Folga changed the title WIP Tgc 476 page templating yes no question Tgc 476 page templating yes no question Nov 7, 2024
@Andrew-Folga Andrew-Folga changed the title Tgc 476 page templating yes no question Tgc 476 + TGC-479 page templating yes no question Nov 7, 2024
@Andrew-Folga Andrew-Folga changed the title Tgc 476 + TGC-479 page templating yes no question TGC-476 + TGC-479 page templating yes no question Nov 7, 2024
@Andrew-Folga Andrew-Folga force-pushed the TGC-476-page-templating-yes-no-question branch from 21f62b9 to 40a90fb Compare November 7, 2024 11:40
@Andrew-Folga
Introduce generic page template
b10b42f
@Andrew-Folga
Add machines shutdown and missing tests
66f96dd
@Andrew-Folga
Fix snapshot test
b6b2192
@Andrew-Folga
Fix sonar issues
78e8cd7
@Andrew-Folga
Add tests for template utils
961c734
@Andrew-Folga
Add next and back click interaction tests
54ecd6f
@Andrew-Folga
Add radio selection to tests
cc30d0a
@Andrew-Folga
Fix sonar issues
6b2ec02
@Andrew-Folga
Update jsdoc descriptions in template utils
b338e80
@Andrew-Folga
Remove cheerio and unused console logs
a50ac5a
@Andrew-Folga
Change cheerio based tests to use jsdom
d7a24d0
@Andrew-Folga
Add hint to country question
039a343
@Andrew-Folga
Update country snapshot
16b0686
@Andrew-Folga
Add sidebar macro and reference it on page template
da843f4
@Andrew-Folga
Update snapshot tests to add sidebar
7f9b164
@Andrew-Folga
Add classes to country question to keep the answers inline
14b9759
@Andrew-Folga
Add classes to second-question for inline radio display
bab81a4
@Andrew-Folga
Move generic templates outisde of example-grant folder and move count…
46747cc 
…ry and start spec files inside example-grant folder
@Andrew-Folga
Remove redirect to start page from final as discussed
9a64af4
@Andrew-Folga Andrew-Folga force-pushed the TGC-476-page-templating-yes-no-question branch from dbc93fa to fc79e09 Compare November 7, 2024 13:13
alanplatt
alanplatt previously approved these changes Nov 7, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
98.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Andrew-Folga Andrew-Folga merged commit da5dac0 into main Nov 7, 2024
11 checks passed
@Andrew-Folga Andrew-Folga deleted the TGC-476-page-templating-yes-no-question branch November 7, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScenarioFactory ScenarioFactory ScenarioFactory approved these changes

@alanplatt alanplatt alanplatt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andrew-Folga @alanplatt @ScenarioFactory