added initial narrow integration tests #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-Folga
force-pushed
the
TGC-451-narrow-integration-smoke-test
branch
from
d77ee31 to
5773c21
Compare
|
This is now complete. The idea is to create server (without starting) as part of the container the tests are run in and use server.inject(...) to bypass networking etc. This PR includes both simple response tests and view tests. |
…with proper hierarchy.
…ntegration tests are added in follow up PR
Andrew-Folga
force-pushed
the
TGC-451-narrow-integration-smoke-test
branch
from
f9fdee3 to
3f971bd
Compare
… test and snapshot tests.
Andrew-Folga
reviewed
Nov 4, 2024
ScenarioFactory
previously approved these changes
Nov 4, 2024
swdpcomputing
commented
Nov 4, 2024
|
ScenarioFactory
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - DO NOT MERGE
Initial thoughts for narrow integrations tests. @alanplatt @Andrew-Folga please check that the urls being checked fit with what we expect after today's work.
UPDATE - WE CAN MERGE IT NOW