fix(AHWR-321): use organisation, not farmer, name #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- stop allowing 404s from contact history (it now returns [] instead) - remove debug logging for auth, just in case we go to prod
mattyod
force-pushed
the
show-organisation-name-AHWR-321
branch
from
6bbc134 to
1674040
Compare
RobCatton
reviewed
Dec 20, 2024
app/api/contact-history.js
Outdated
| } | ||
| } | ||
|
|
||
| const getContactFieldData = (contactHistoryData, field) => { | ||
| const filteredData = contactHistoryData.filter(contact => contact?.data?.field === field) | ||
| const filteredData = contactHistoryData.filter(contact => contact.data?.field === field) | ||
| if (filteredData.length) { |
There was a problem hiding this comment.
Not your code I know, but could we swap this around so we have
if (!filteredData.length) return 'NA'
And then we can have the happy path underneath, no need for an else?
There was a problem hiding this comment.
Go on then. Though I prefer positive assertions, so used if (filteredData.length === 0)
bendef-24
previously approved these changes
Dec 20, 2024
Remove lodash references (it's not a direct dependency)
RobCatton
approved these changes
Dec 23, 2024
|
aaroncarroll82
added a commit
that referenced
this pull request
Dec 24, 2024
* fix(AHWR-321): use organisation, not farmer, name - stop allowing 404s from contact history (it now returns [] instead) - remove debug logging for auth, just in case we go to prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/view-claim/CLAIM_ID
Before:
After:
/agreement/AGREEMENT_ID/claims
Before:
After:
