Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mojui #24

Merged
merged 23 commits into from
Aug 8, 2022
Merged

Feature/mojui #24

merged 23 commits into from
Aug 8, 2022

Conversation

govTechSatish
Copy link
Contributor

No description provided.

@govTechSatish govTechSatish marked this pull request as ready for review July 28, 2022 11:08
steve-dickinson
steve-dickinson reviewed Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@steve-dickinson steve-dickinson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for now, but I think we need to look at raising a tech debt ticket for reducing and tidying up the code within the routes.

steve-dickinson
steve-dickinson requested changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@steve-dickinson steve-dickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status sort doesn't seem to be working as expected. I have both Applied and claimed statuses and the Claimed status remains with the middle of the reords.

@steve-dickinson steve-dickinson self-requested a review August 1, 2022 09:22
steve-dickinson
steve-dickinson previously approved these changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@steve-dickinson steve-dickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@govTechSatish govTechSatish merged commit 792d297 into main Aug 8, 2022
@govTechSatish govTechSatish deleted the feature/mojui branch August 8, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivanshuit914 shivanshuit914 shivanshuit914 approved these changes

@steve-dickinson steve-dickinson steve-dickinson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@govTechSatish @shivanshuit914 @steve-dickinson