-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-work CPH query #106
re-work CPH query #106
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase rather than merge from dev
? It would be good to keep the commit history as clear and uncluttered as possible.
test/unit/transformers/rural-payments-portal/business-cph.test.js
Outdated
Show resolved
Hide resolved
1a8189f
to
21d2ca8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* re-work CPH query * change startDate and expiryDate to Date type * add example to CHP number field comment
No description provided.