Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-work CPH query #106

Merged
merged 3 commits into from
Nov 22, 2024
Merged

re-work CPH query #106

merged 3 commits into from
Nov 22, 2024

Conversation

csaltmountain
Copy link
Collaborator

No description provided.

Copy link

sonarcloud bot commented Nov 15, 2024

@csaltmountain csaltmountain changed the base branch from main to dev November 19, 2024 13:52
Copy link
Collaborator

@defra-dom defra-dom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rkdefra rkdefra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase rather than merge from dev? It would be good to keep the commit history as clear and uncluttered as possible.

app/graphql/types/business/cph.gql Show resolved Hide resolved
app/transformers/rural-payments/business-cph.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@rkdefra rkdefra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csaltmountain csaltmountain merged commit 3d7594e into dev Nov 22, 2024
5 checks passed
@csaltmountain csaltmountain deleted the feature/cph-details branch November 22, 2024 10:45
csaltmountain added a commit that referenced this pull request Dec 3, 2024
* re-work CPH query

* change startDate and expiryDate to Date type

* add example to CHP number field comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants