SRT Input Fixes - streamid not sanitized when pushing to wildcard stream; config options ignored #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing to an SRT input (srt://:[PORT]), the incoming streamid was not sanitized the way it is done in
mistserver/src/output/output_tssrt.cpp
Line 122 in d1cb436
Currently all configuration options for SRT inputs are ignored and defaults are used. The easiest way to test this is to set the "Acceptable pushed streamids:" option to "Ignore..." (1) and push an srt stream with a stream id. The expected behavior is to discard stream ID and not treat the stream name as wildcard. In the release, the server behaves as if this option is set to 0 (default) - "Set Streamid as wildcard", regardless of what actual setting is used. This happens because when config->addOption() is invoked the second time after the config has already been initialized in a constructor called in a thread, it erases the option values passed via the command line and resets them to default. f20826c is the fix.
Added logging of incoming streamid at INFO level before it is sanitized - good for troubleshooting (aafa359)