Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRT Input Fixes - streamid not sanitized when pushing to wildcard stream; config options ignored #219

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

m1tk4
Copy link

@m1tk4 m1tk4 commented Jan 3, 2025

  1. When pushing to an SRT input (srt://:[PORT]), the incoming streamid was not sanitized the way it is done in

    Util::sanitizeName(streamName);
    . Some encoders (Blackmagic Design WebPresenter) send a fixed streamid that has special characters - BMD's look like '#!::bmd_uuid=460b34e1-0d3d-4758-ba7e-f9409f79be20,bmd_name=devicename'. When new streams created with these names unsanitized, a lot of things break. Fix is 72689a8

  2. Currently all configuration options for SRT inputs are ignored and defaults are used. The easiest way to test this is to set the "Acceptable pushed streamids:" option to "Ignore..." (1) and push an srt stream with a stream id. The expected behavior is to discard stream ID and not treat the stream name as wildcard. In the release, the server behaves as if this option is set to 0 (default) - "Set Streamid as wildcard", regardless of what actual setting is used. This happens because when config->addOption() is invoked the second time after the config has already been initialized in a constructor called in a thread, it erases the option values passed via the command line and resets them to default. f20826c is the fix.

  3. Added logging of incoming streamid at INFO level before it is sanitized - good for troubleshooting (aafa359)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant