Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tried to stitch lots of images and have to correct some bugs of shift estimation #10

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ValeriePineauNoel
Copy link
Collaborator

Small modifications to the code to optimize the stitching.

  • The horizontal stitch now is also cropped and low-pass filtered previous to the shift estimation with the phase cross-correlation.
  • Useless prints were deleted.

@ValeriePineauNoel ValeriePineauNoel self-assigned this Aug 3, 2022
Copy link

@dccote dccote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One function, one thing: each function must do only one thing. Split the Stitching function into loadImages() and stitchMap()

@@ -19,7 +19,7 @@
#
#enveloppe = img.correct_intensity_envelop()

stitch = Stitching(sourceDir=sourcePath, tileD=tileDimensions, imageSize=[1024,512], isIntensityCorrection=True, isMirrored=True, isFlipped=False)
stitch = Stitching(sourceDir=sourcePath, tileD=tileDimensions, imageSize=[1024,512], isIntensityCorrection=False, isMirrored=True, isFlipped=False)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split the loading of images and the stitching of images in two different functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants