Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve with filter example doesn't return expected results #24

Open
brynrhodes opened this issue Apr 26, 2018 · 6 comments
Open

Retrieve with filter example doesn't return expected results #24

brynrhodes opened this issue Apr 26, 2018 · 6 comments
Assignees

Comments

@brynrhodes
Copy link
Contributor

The example "Retrieve with filter" is not returning the expected results.

First, the example is looking for a clincalStatus of inactive, it should be active.

Even addressing that, the definition:

define MalignantNeoplasmConditions:
  [Condition: "Malignant Neoplasm of Colon"] C
    where C.clinicalStatus.value = 'active'
      and C.verificationStatus.value = 'confirmed'

Returns:

>> MalignantNeoplasmConditions [20:1] []

We confirmed via http://measure.eval.kanvix.com/cqf-ruler/baseDstu3/Condition?patient=Patient-12214 that this patient has a condition with SNOMED code 363414004.

We also confirmed via http://measure.eval.kanvix.com/cqf-ruler/baseDstu3/ValueSet/2.16.840.1.113883.3.464.1003.108.11.1001 that this value set contains the code 363414004.

@mjkemna
Copy link

mjkemna commented Feb 24, 2020

I can verify that this is still a relevant issue. Please let me know if this project is still in active development, then I will add my specific findings.

I also believe that this is visible in the CCS example of the cql runner in action. The example patient that should be in the numerator (Patient Id: Patient-6520), isn't actually flagged for the numerator:

>> Numerator [68:1] false

Isn't this a bug related to cql-engine instead of the runner?

@c-schuler
Copy link
Contributor

Hi @mjkemna. I believe you're referring to the quality measure exercise for CCS. Did you complete the exercise and not get the expected results? The CCS Example is actually the answer key for that example.

@mjkemna
Copy link

mjkemna commented Feb 24, 2020

Hi @c-schuler , yes I am referring to that example. If you use the answer key as code and run it with Patient-6520, then I presume that the expected result should be:

>> Numerator [68:1] true

but the following answer is given:

>> Numerator [68:1] false

I believe it is related to the same issue that @brynrhodes describes (and actually a bug in the cql_engine). I can give you a more narrow test fixture to explain the issue in more detail.

@c-schuler
Copy link
Contributor

I have confirmed that the example runs as expected.
Note line 37 in the example CQL:
// Change the Measurement Period year to 1997 for the In Numerator Patient test
If you copy/paste and then change the year to 1997 for the Measurement Period, you should get the expected result.

@mjkemna
Copy link

mjkemna commented Feb 24, 2020

Thanks @c-schuler, I did not see the comment that was removed in the answer key. It is working as expected with the line change. Is there another communication channel that I can contact you or someone else of the active development team?

@c-schuler
Copy link
Contributor

My email is available on my profile page (on the left sidebar). Thanks @mjkemna!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants