Drop test_logical_device_view_contents
#319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @lifflander |
JacobDomagala
force-pushed
the
rm_kokkos_logical_memory_space
branch
from
16a38e8 to
c281e5a
Compare
|
Made some changes to satisfy the CI checks. Only the "incorrect branch name" is left, but I think we can just force merge it. |
Thanks. I don't think I can rename my branch w/o the PR getting closed so maybe that would be better if we merge as is. |
JacobDomagala
force-pushed
the
rm_kokkos_logical_memory_space
branch
from
c281e5a to
fb278fc
Compare
JacobDomagala
force-pushed
the
rm_kokkos_logical_memory_space
branch
from
fb278fc to
23c50b7
Compare
|
@dalg24 Can you rebase this PR? We are ready to merge! |
lifflander
approved these changes
Mar 6, 2024
…s::Experimental::LogicalMemorySpace was removed in kokkos/kokkos#6557
JacobDomagala
force-pushed
the
rm_kokkos_logical_memory_space
branch
from
23c50b7 to
e9f9bf4
Compare
|
@lifflander Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324
Since Kokkos::Experimental::LogicalMemorySpace was removed in kokkos/kokkos#6557
This will be released in Kokkos 4.3
This was discussed with @lifflander at SC23 and there was no objection to removing it.