Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter notebook for reusing_functions example (reusing_functions #1179) #1189

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

eoagyen
Copy link
Contributor

@eoagyen eoagyen commented Oct 16, 2024

This PR adds a Jupyter Notebook for the reusing_functions example to provide a less intimidating entry point for data scientists who prefer using notebooks over Python scripts. The notebook mirrors the functionality of the existing main.py file, enabling users to experiment and try things out interactively.

Changes

A Jupyter notebook was added for the reusing_functions example. The notebook mirrors the functionality of main.py.

How I tested this

Tested the notebook by running all cells and verifying that the outputs match those from main.py. Ensured that all functions and processes work as expected within the notebook environment.

Notes

  • This is part of an ongoing effort to provide Jupyter notebooks for all examples to make them more accessible for data scientists.
  • No major changes were made to the underlying code; the notebook serves as an alternative to main.py.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped PR review on 99ad262 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.


Generated with ❤️ by ellipsis.dev

removing import -- not needed.
updates driver creation to latest approach.
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this!

Notes for future.
(1) You don't need to import modules with the hamilton code because the cells will define it.
(2) We are moving away from the legacy pattern of building the Driver object, and instead doing it via the driver.Builder() object instead.

@skrawcz skrawcz merged commit 7b9f52a into DAGWorks-Inc:main Oct 16, 2024
21 of 24 checks passed
@skrawcz skrawcz added the hacktoberfest Hacktoberfest issues label Oct 16, 2024
@skrawcz skrawcz linked an issue Oct 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reusing_functions
2 participants