Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up our design discussion on caching and fingerprinting. Here are the basic working mechanisms for caching as we discussed.
Composable parts:
{execution context: fingerprint}
{fingerprint: result / data}
TODO
node_name
metadata in the fingerprint store. This is very easy withdiskcache
node_name
metadata is absent)SmartCache(fingerprints={...})
(which could be hidden beind a singlerun_id
). Then the adapter will use these fingerprints to read from the result store instead of trying to compute these fingerprints or load them from the fingerprint store.Store
objects.get
andset
are required, but unclear ifopen()
andclose()
are necessary for all (could be null operations)MaterializerStore
whereget()
andset()
are materializers