Expose default values in HamiltonNode
#710
Labels
enhancement
New feature or request
Comments
|
relates to #495 |
skrawcz
added a commit
that referenced
this issue
Jul 18, 2024
This fixes #710. This hasn't been extensively tested, but this seems to work and pass things through as expected. There is a JSON serialization caveat, however we expect default values to be primitives so that should be fine. If not the user can augment the dictionary returned ...
7 tasks
skrawcz
added a commit
that referenced
this issue
Aug 28, 2024
This fixes #710. This hasn't been extensively tested, but this seems to work and pass things through as expected. There is a JSON serialization caveat, however we expect default values to be primitives so that should be fine. If not the user can augment the dictionary returned ...
skrawcz
added a commit
that referenced
this issue
Aug 28, 2024
* Implements #710 optional value exposure This fixes #710. This hasn't been extensively tested, but this seems to work and pass things through as expected. There is a JSON serialization caveat, however we expect default values to be primitives so that should be fine. We default to not returning optional values in this case, and users must request it themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
We have
optional_dependenciesbut its just a set. We don't expose it.Describe the solution you'd like
We should have a
default_valuesfield or something like that.Dict[str, Any].Describe alternatives you've considered
People can inspect the function -- see https://github.com/DAGWorks-Inc/hamilton/blob/main/hamilton/plugins/h_experiments/hook.py for instance.
Additional context
Feature request from OS. This is tricky as we don't capture it, but should be possible with a bit of rewiring.
The text was updated successfully, but these errors were encountered: