Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndjson #1197

Open
Tracked by #792
skrawcz opened this issue Oct 21, 2024 · 4 comments
Open
Tracked by #792

ndjson #1197

skrawcz opened this issue Oct 21, 2024 · 4 comments
Assignees
Labels
hacktoberfest Hacktoberfest issues hacktoberfest2024 hacktoberfest 2024

Comments

@skrawcz
Copy link
Collaborator

skrawcz commented Oct 21, 2024

Implement ndjson https://docs.pola.rs/api/python/stable/reference/api/polars.read_ndjson.html and https://docs.pola.rs/api/python/stable/reference/api/polars.DataFrame.write_ndjson.html as a data saver/loader.

It should go into https://github.com/DAGWorks-Inc/hamilton/blob/main/hamilton/plugins/polars_post_1_0_0_extensions.py, one class for the writer, on class for the reader, e.g. much like how the polars json reader and writer are structured.

There should be requisite tests to exercise the functionality. We can do one test that writes & then reads it's own output.
Then an example should be added to the directory called materialization under example/polars. It should mirror the current structure in there.
If there's an issue with type hints, let me know and we can chat through it.

@iblameRishi
Copy link

Hi @skrawcz , thanks for the detailed instructions!

@skrawcz
Copy link
Collaborator Author

skrawcz commented Nov 5, 2024

@iblameRishi need any pointers? are you still interested in this task?

@iblameRishi
Copy link

Hey, sorry yes still interested! will make the PR by tomo

@skrawcz
Copy link
Collaborator Author

skrawcz commented Nov 18, 2024

@iblameRishi just checking in. How are things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest issues hacktoberfest2024 hacktoberfest 2024
Projects
None yet
Development

No branches or pull requests

2 participants