Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoting multiple #433

Merged
merged 9 commits into from
Aug 10, 2022
Merged

Revoting multiple #433

merged 9 commits into from
Aug 10, 2022

Conversation

bekauz
Copy link
Collaborator

@bekauz bekauz commented Aug 3, 2022

Closes #367

Follows the style of revoting implemented on proposal-single

Copy link
Contributor

@0xekez 0xekez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, this looks perfect. Amazing work. Thank you!

Want to let this simmer in my brain for a day. Will come back and give another pass and (likely) approve tomorrow!

Copy link
Contributor

@0xekez 0xekez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING work! Congrats on your first DAO DAO contribution. :)

Feel free to merge when ready. Will need to do a rebase though it's only in the schemas so I'd (1) rebase, (2) delete all the schema and typescript stuff, (3) regenerate from a clean slate.

@bekauz bekauz force-pushed the revoting-multiple branch from 92691b4 to 33480b5 Compare August 10, 2022 19:18
@0xekez 0xekez merged commit ee2a848 into DA0-DA0:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'allow revoting' to multiple choice proposals
4 participants