Update ToCoroutineEnumerator<T> to return a T? from Current instead of object #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCrossBoy
changed the title
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToCoroutine<T>()provides an excellent way to port existing synchronous calls to asynchronous without needing to fully rewrite everything - when inside a coroutine, it can be yielded instead.To get the value that the previously-synchronous function would have returned, you use
.Current. Right now,Currentis anobject, when it should be aT. I think this might have been to avoid problems with non-nullable / reference types, so I wrapped it inNullable(withT?).Eliminates extra unnecessary typecasting with this.