Skip to content

Sync PR #990 fix to Japanese and Korean documentation#995

Merged
mayuki merged 2 commits intomainfrom
copilot/apply-fixes-to-language-docs
Dec 4, 2025
Merged

Sync PR #990 fix to Japanese and Korean documentation#995
mayuki merged 2 commits intomainfrom
copilot/apply-fixes-to-language-docs

Conversation

Copy link
Contributor

Copilot AI commented Dec 4, 2025

PR #990 corrected a code example in the StreamingHub getting started guide, but only updated the English version. This applies the same fix to Japanese and Korean translations.

Changes

  • Japanese: docs/i18n/ja/docusaurus-plugin-content-docs/current/streaminghub/getting-started.md
  • Korean: docs/i18n/ko/docusaurus-plugin-content-docs/current/streaminghub/getting-started.md

Both files now correctly use userName instead of ConnectionId.toString() in the LeaveAsync() method example:

 public async ValueTask LeaveAsync()
 {
-    room.All.OnLeave(ConnectionId.toString());
+    room.All.OnLeave(userName);
     await room.RemoveAsync(Context);
 }
Original prompt

This section details on the original issue you should resolve

<issue_title>Apply the fixes from pull requests to the doc for each language.</issue_title>
<issue_description>Apply the pull request fixes that have been applied to recently updated documents to each language's documentation.

  • docs/docs: English (en-us)
  • docs/i18n/ja/docusaurus-plugin-content-docs: Japanese
  • docs/i18n/ko/docusaurus-plugin-content-docs: Korean</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: mayuki <9012+mayuki@users.noreply.github.com>
Copilot AI changed the title [WIP] Apply pull request fixes to language documentation Sync PR #990 fix to Japanese and Korean documentation Dec 4, 2025
Copilot AI requested a review from mayuki December 4, 2025 06:05
@mayuki mayuki marked this pull request as ready for review December 4, 2025 06:14
@mayuki mayuki merged commit 775bc43 into main Dec 4, 2025
2 checks passed
@mayuki mayuki deleted the copilot/apply-fixes-to-language-docs branch December 4, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply the fixes from pull requests to the doc for each language.

2 participants