Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical issue with CancellationToken handling in StreamingHub client connections. The change ensures that canceling the CancellationToken passed to ConnectAsync after the connection is established (but before the first message arrives) no longer incorrectly cancels the message reading loop.
Key Changes:
- Modified
reader.MoveNextto use onlysubscriptionTokeninstead of a linked token that includesconnectAndSubscribeCancellationToken - Improved error message clarity for server version negotiation failures
- Added comprehensive test coverage for the cancellation scenario
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/MagicOnion.Client/StreamingHubClientBase.cs | Removed connectAndSubscribeCancellationToken from the first MoveNext call to prevent premature cancellation of message reading; improved error message for missing server version |
| tests/MagicOnion.Client.Tests/StreamingHubTest.cs | Added test ConnectAsync_CancellationToken_Timeout_On_FirstMoveNext to verify canceling the connect token after connection doesn't affect message processing; added explicit using System.Threading directive |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This was referenced Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of the CancellationToken when clients connect.
It resolves an issue where canceling the CancellationToken passed to ConnectAsync immediately after calling ConnectAsync, before the first message arrives, would cancel message reading.