Skip to content

Update streaminghub/getting-started.md #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayuki merged 1 commit into from
Dec 4, 2025
Merged

Update streaminghub/getting-started.md #990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/docs/streaminghub/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public class ChatHub : StreamingHubBase<IChatHub, IChatHubReceiver>, IChatHub

public async ValueTask LeaveAsync()
{
room.All.OnLeave(ConnectionId.toString());
room.All.OnLeave(userName);
await room.RemoveAsync(Context);
Comment on lines +154 to 155
Copy link
Contributor Author

@iiweis iiweis Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought RemoveAsync should be called first here, but I left it as is.
By the way, in the implementation of samples/ChatApp, RemoveAsync is called first.

MagicOnion/samples/ChatApp/ChatApp.Server/ChatHub.cs

Lines 40 to 41 in e79d6de

await this.room.RemoveAsync(this.Context);
this.room.All.OnLeave(this.myName);

}

Expand Down