Fix for underscore to dash conversion #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHCP OMAPI normally uses dashes as a separator for field words. Python does not accept dashes in kwarg keys, so there is a conversion in the __lookup function to convert _ to -. However, there seems to be a bug that prevents that conversion to be actually used for some parameters.
cygnusb
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHCP OMAPI normally uses dashes as a separator for field words. Python does not accept dashes in kwarg keys, so there is a conversion in the
__lookupfunction to convert _ to -. However, there seems to be a bug that prevents that conversion to be actually used for some parameters.Tested on one of instances of dhcpd and I saw the right names (e.g.
client-hostname) in the dump. (However not all fields are supported in ISC in the lookup.)