-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new method add_host_with_statements #27
Conversation
3511df6
to
0efb9f3
Compare
Thanks for your contribution. Please provide a pull request without the version bump. Thanks! |
@cygnusb Done. Thanks. |
Please create one clean merge request containing only the minimal changeset and not version change and revert of version change. Thanks. |
@cygnusb I did revert the version bump. Do you see it? If you'd like to merge this as a single commit, you can 'squash merge' it. If not i can make this into a single commit. Let me know. |
43fee89
to
7383eff
Compare
@cygnusb Just made it into a one clean commit now. Removed the version stuff. |
Please change the function parameters to not be kwargs. For the optional parameters you can use None as default value. |
7383eff
to
6a91bcb
Compare
@cygnusb Yes. I have removed the kwargs. |
Please add documentation for all parameters. See other functions as reference |
And please reorder parameters, to be in sync with def add_host_supersede_name. |
6a91bcb
to
6d2874c
Compare
@cygnusb reordered the parameters, renamed the method to add_host_supersede, added doctrings about the parameter types. Thanks for taking time to review. Let me know if you want me to change anything else. |
The check for name, ip and mac is now obsolete and can be removed. In addition also the "if ip" statement below can be removed. |
We want to set hostname, routers and domain in the dhcp lease file. The method add_host_supersede accepts router,domain and hostname and sets those statements using omapi in the lease file. The method also handles case when any of the statements are missing/not passed by the user.
6d2874c
to
7d1d771
Compare
@cygnusb Done. Thanks. |
Thank you! |
@cygnusb Any chance it will get pushed to pypi? I still see 0.6 in pypi, can you make a release please? |
We want to set hostname, routers and domain in the dhcp lease file.
The method add_host_with_statements accepts router,domain and hostname
and sets those statements using omapi in the lease file. The method
also handles case when any of the statements are missing.