Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix ProtoBuf breaking detection to be wire-only #532

Merged
merged 3 commits into from
Nov 4, 2024
Merged

tests: fix ProtoBuf breaking detection to be wire-only #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db82972
tests: fix ProtoBuf breaking detection to be wire-only
jkowalleck Nov 4, 2024
a9dac71
adjust test runners
jkowalleck Nov 4, 2024
cf72b7f
use only wire
jkowalleck Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tools/src/test/proto/buf_breaking-remote.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@
version: v1
breaking: # https://buf.build/docs/configuration/v1/buf-yaml#breaking
use: # see https://buf.build/docs/breaking/overview#rules-and-categories
- FILE
- WIRE_JSON
- WIRE
3 changes: 1 addition & 2 deletions tools/src/test/proto/buf_breaking-version.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
version: v1
breaking: # https://buf.build/docs/configuration/v1/buf-yaml#breaking
use: # see https://buf.build/docs/breaking/overview#rules-and-categories
- FILE
- WIRE_JSON
- WIRE
except:
# scope is to detect changes from one version to the other -> so ignore "FILE_SAME_PACKAGE"
- FILE_SAME_PACKAGE
2 changes: 1 addition & 1 deletion tools/src/test/proto/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function schema-breaking-version () {
}

compare '1.6' '1.5'
echo '>> skip compare' '1.5' '1.4' >&2 # <-- had breaking changes, which is acknowledged
compare '1.5' '1.4'
compare '1.4' '1.3'

echo '>> OK.' >&2
Expand Down