fix: ProtoBuf evidence not repeated, but optional #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Kowalleck <[email protected]>
jkowalleck
force-pushed
the
fix/protobuf-component-evidence-not-repeated
branch
from
db3abbe to
b3d9a2b
Compare
stevespringett
approved these changes
Aug 31, 2024
|
@stevespringett, I think this merge should be reverted. tools generating ProtBuff messages for the current stable release this would also reopen #422 . |
jkowalleck
added a commit
to jkowalleck/fork_CycloneDX-specification
that referenced
this pull request
Sep 4, 2024
Signed-off-by: Jan Kowalleck <[email protected]>
Merged
jkowalleck
added a commit
that referenced
this pull request
Sep 4, 2024
This PR reverts previously wrong merge of PR #425 (which introduced unexpected breaking-changes) See #425 (comment) reopen #422 Signed-off-by: Jan Kowalleck <[email protected]>
jkowalleck
added a commit
that referenced
this pull request
Sep 4, 2024
…ated (#517) non-breaking fix of #422 in contrast to #425 Signed-off-by: Jan Kowalleck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #422
and yes, fixing this bug is actually considered a breaking change in terms of ProtoBuf