-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] docs: add testResources JSON $schema
#255
[WIP] docs: add testResources JSON $schema
#255
Conversation
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
$schema
failing tests showed the importance to fix the |
…ces-json-add-schema
the Java tests still fail. how should it be spossible to test the schema against the examples, if the java test do not run on the schema files in this repo? how to test, if the schema files do change? how to test if the schema files in this repo are any good? The current implementation of JS and PHP uses the files in this repo for validation of the valid/invalid testResources ... @stevespringett please help. PS: caused #256 |
Traditionally, how it's been working is that once changes are made to the schema development branch, those changes are mirrored to the Core Java library and published as a SNAPSHOT release. We keep the snapshots up to date with the latest schemas. It has not been synchronized. |
re: #255 (comment) Therefore, #256 was created with its acceptance criteria. |
Why are there 144 files changed? We cannot accept this PR. Also, why would test files be required to have the $schema? That makes absolutely no sense. For example |
re: #255 (comment)
Please read #254 to understand the motivation. Then you will see why this makes total sense for the mentioned use case ;-)
Now you see the hassle everybody goes through who is already referencing the existing schemas files. If we in-place-change the
Thanks for the heads-up. This PR is a draft, it is in the making, no final solution.
|
$schema
$schema
i might rework the content of this PR, and might come up with a followup. |
fixes: #254 followup of: #403 supersedes: #255 Signed-off-by: Jan Kowalleck <[email protected]>
Superseded by #423 |
$schema
to json test resources$schema
enumpart of #254
blocked by #256
supersedes #138