Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce type for BOM-Link #235

Merged

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jun 3, 2023

caused by #217

Introduction of bomLink types,
so that they can be used where needed, later.

This should allow formulating the answer for #136 and #217 in the schema,
so that there would be clarity.

@jkowalleck jkowalleck requested a review from a team June 3, 2023 12:54
@jkowalleck jkowalleck force-pushed the introduce-type-for-bomLink branch from e43040c to d235cc5 Compare June 3, 2023 12:56
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck force-pushed the introduce-type-for-bomLink branch from d235cc5 to 10618e8 Compare June 3, 2023 12:58
@stevespringett
Copy link
Member

This looks good to me. First thing I verified was that anchors were correctly used in the JSON schema and correctly omitted from the XSD. So technically, I think the PR is sound.

@stevespringett stevespringett added this to the 1.5 milestone Jun 3, 2023
@jkowalleck
Copy link
Member Author

jkowalleck commented Jun 3, 2023

I am uncertain about the ProtoBuff. Unclear whether to introduce the types there, too. (I did not find how union types are defined in ProtoBuff)
What do you think, @stevespringett, should we add there, too ?


i'd suggest to merge this then,
and after the merge I'll prepare followup-PRs to formulate/clarify which elements allow BOM-Link as a formal value; I will prepare initial branch and PR for this, but might need assistance to finalize it.

@stevespringett
Copy link
Member

I don't think regex is supported in protobuf. I belive we are omitting serialNumber, CPE, and a few other validations because of this.

Ok to merge.

@stevespringett stevespringett merged commit 36ac6cd into CycloneDX:v1.5-dev Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants