Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GH-workflow: php ci #110

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Dec 23, 2021

part of #86 for #123

  • added the existing php tests as a GitHub workflow
  • slight fixes and extensibility-modifications to existing php test-setup

☝️ PHP CI is currently failing, since some JSON schema files are not entirely valid/plausible - which is topic of #83/#123
this might be fixed via (#84/#125/...) - #124
as soon as the JSON schema files were fixed, they will pass.
Then these test can act as a gatekeeper.

@jkowalleck jkowalleck force-pushed the gh-workflow_php-ci branch 2 times, most recently from 09d6512 to 3f38648 Compare December 23, 2021 12:23
@jkowalleck jkowalleck changed the base branch from v1.4-dev to master February 4, 2022 13:52
@jkowalleck
Copy link
Member Author

updated the test and pointed the PR to master,
in preparation for #123

@jkowalleck
Copy link
Member Author

this PR detechts and chcks the relevant issues from #123

logs show only the first error for each file - example:

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/bom-1.2-strict.schema.json
SCHEMA ERROR: Duplicate schema id: http://cyclonedx.org/schema/bom-1.2a.schema.json#/properties/components

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/bom-1.2.schema.json
OK.

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/bom-1.3-strict.schema.json
SCHEMA ERROR: Duplicate schema id: http://cyclonedx.org/schema/bom-1.3.schema.json#/properties/components

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/bom-1.3.schema.json
OK.

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/bom-1.4.schema.json
OK.

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/jsf-0.82.schema.json
OK.

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/spdx.schema.json
OK.

https://github.com/CycloneDX/specification/runs/5067469700?check_suite_focus=true#step:5:7

@stevespringett
Copy link
Member

Whats the status of this PR?

@jkowalleck
Copy link
Member Author

jkowalleck commented Mar 7, 2022

implementation tests all the JSON schema files.
the PR is ready for merge,

the github action "PHP CI" will fail, as long/soon as the json schema files are invalid.

once again rebased onto latest master.
latest output shows, that all schema fiiles are fine, now: https://github.com/CycloneDX/specification/runs/5445435252?check_suite_focus=true#step:5:7

> @php -f json-schema-lint-tests.php --

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/bom-1.2-strict.schema.json
OK.

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/bom-1.2.schema.json
OK.

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/bom-1.3-strict.schema.json
OK.

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/bom-1.3.schema.json
OK.

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/bom-1.4.schema.json
OK.

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/jsf-0.82.schema.json
OK.

SchemaFile: /home/runner/work/specification/specification/tools/src/test/php/../../../../schema/spdx.schema.json
OK.

Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck force-pushed the gh-workflow_php-ci branch from 83aad76 to 6623705 Compare March 7, 2022 08:48
@stevespringett stevespringett merged commit 82bf9e3 into CycloneDX:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants