fix: no warning for missing dependencies if no component exists #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: weichslgartner <[email protected]>
weichslgartner
force-pushed
the
bugfix_dependency_warning_617
branch
from
be95494
to
9aff926
Compare
jkowalleck
requested changes
Oct 23, 2024
jkowalleck
approved these changes
Oct 24, 2024
jkowalleck
changed the title
|
@madpah , what do you think about this change? |
jkowalleck
requested changes
Oct 28, 2024
Signed-off-by: weichslgartner <[email protected]>
jkowalleck
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a condition to check if the root component is the only component and then doesn't issue the warning. Closes #617