Skip to content

feat: Optional dependencies - #657

Merged
jkowalleck merged 13 commits into
mainfrom
optional-dependencies
Apr 16, 2023
Merged

feat: Optional dependencies#657
jkowalleck merged 13 commits into
mainfrom
optional-dependencies

Conversation

@jkowalleck

@jkowalleck jkowalleck commented Apr 16, 2023

Copy link
Copy Markdown
Member

fixes #645


  • Added
    • SBOM result might have component.scope=optional populated for OptionalDependencies
  • Fixed
    • DevDependencies that are also required by OptionalDependencies correctly have the property cdx:npm:package:development populated in SBOM results
    • DevDependencies that are also required by OptionalDependencies are correctly omitted from SBOM results, when the CLI switch for omitting "dev" and "optional" are set

implement feat/fix

  • "dev": true
  • "devOptional": true
  • "optional": true

have demos available

  • "dev": true
  • "devOptional": true
  • "optional": true

tests from demo data

history / change log

  • "devOptional": true
  • "optional": true

chores

  • update demos' results

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added bug Something isn't working enhancement New feature or request demo regardng the demos labels Apr 16, 2023
@jkowalleck
jkowalleck force-pushed the optional-dependencies branch from a418390 to e62797a Compare April 16, 2023 12:05
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title [WIP] Optional dependencies Optional dependencies Apr 16, 2023
@jkowalleck jkowalleck self-assigned this Apr 16, 2023
@jkowalleck
jkowalleck marked this pull request as ready for review April 16, 2023 17:55
@jkowalleck
jkowalleck requested a review from a team as a code owner April 16, 2023 17:55
Comment thread src/builders.ts Outdated
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title Optional dependencies feat: Optional dependencies Apr 16, 2023
@jkowalleck jkowalleck removed the bug Something isn't working label Apr 16, 2023
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
jkowalleck merged commit 39ae1d5 into main Apr 16, 2023
@jkowalleck
jkowalleck deleted the optional-dependencies branch April 16, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

demo regardng the demos enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dev/optional component flag

1 participant