Skip to content

docs: document how to change npm executable - #647

Merged
jkowalleck merged 5 commits into
CycloneDX:mainfrom
igord:docs-npm-exec-path
Apr 16, 2023
Merged

docs: document how to change npm executable#647
jkowalleck merged 5 commits into
CycloneDX:mainfrom
igord:docs-npm-exec-path

Conversation

@igord

@igord igord commented Apr 14, 2023

Copy link
Copy Markdown
Contributor
  • Docs
    • Describe internal npm executable detection in README

Signed-off-by: Igor Dimitrijevic <grmail@gmail.com>
@igord
igord requested a review from a team as a code owner April 14, 2023 15:34

@jkowalleck jkowalleck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the enhancement. could you incorporate some changes?

Comment thread README.md Outdated
Comment thread README.md Outdated
@jkowalleck jkowalleck added the documentation Improvements or additions to documentation label Apr 14, 2023
@jkowalleck

jkowalleck commented Apr 14, 2023

Copy link
Copy Markdown
Member

Thanks for the documentation, @igord .

Could you sign-off your commits, to show that you agree publising your contribution under the current license of this project?
see https://github.com/CycloneDX/cyclonedx-node-npm/blob/main/CONTRIBUTING.md#sign-off-your-commits

ℹ️ how to :
see https://github.com/CycloneDX/cyclonedx-node-npm/pull/647/checks?check_run_id=12756708646

Igor Dimitrijevic added 2 commits April 14, 2023 19:06
Signed-off-by: Igor Dimitrijevic <grmail@gmail.com>
Signed-off-by: Igor Dimitrijevic <grmail@gmail.com>
@igord
igord force-pushed the docs-npm-exec-path branch from 5261112 to 4df40ce Compare April 14, 2023 17:13
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
jkowalleck merged commit ee49351 into CycloneDX:main Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants