Skip to content

feat: render property cdx:reproducible - #1373

Merged
jkowalleck merged 8 commits into
CycloneDX:mainfrom
AradhyaTiwari10:render-property-cdx-reproducible
Oct 29, 2025
Merged

feat: render property cdx:reproducible#1373
jkowalleck merged 8 commits into
CycloneDX:mainfrom
AradhyaTiwari10:render-property-cdx-reproducible

Conversation

@AradhyaTiwari10

@AradhyaTiwari10 AradhyaTiwari10 commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

Adds a cdx:reproducible property under metadata.properties to indicate whether the SBOM was built in reproducible mode.
This fulfills issue #1054 (Hacktoberfest).
I tested it locally through:
npx cyclonedx-npm --output bom.json
Output was:

"properties": [
  {
    "name": "cdx:reproducible",
    "value": "false"
  }
]

Note: Some integration tests may fail due to snapshot mismatches from previous versions. The functionality itself works as expected.

@AradhyaTiwari10
AradhyaTiwari10 requested a review from a team as a code owner October 28, 2025 09:39
@jkowalleck jkowalleck linked an issue Oct 28, 2025 that may be closed by this pull request
@jkowalleck jkowalleck added the enhancement New feature or request label Oct 28, 2025
@jkowalleck

jkowalleck commented Oct 28, 2025

Copy link
Copy Markdown
Member

Note: Some integration tests may fail due to snapshot mismatches from previous versions. The functionality itself works as expected.

please create the snapshots as needed.
see https://github.com/CycloneDX/cyclonedx-node-npm/blob/main/CONTRIBUTING.md
and

const UPDATE_SNAPSHOTS = !!process.env.CNPM_TEST_UPDATE_SNAPSHOTS

Comment thread bom.json Outdated
Comment thread src/builders.ts
@jkowalleck

Copy link
Copy Markdown
Member

@AradhyaTiwari10

Copy link
Copy Markdown
Contributor Author

Thanks for the detailed feedback, @jkowalleck
I’ll address the requested changes right away:

I’ll remove the unintended bom.json file.

I’ll restore the src/builders.ts content that deletion was accidental.

I’ll re run the integration tests with CNPM_TEST_UPDATE_SNAPSHOTS=1 to regenerate snapshots as per the contribution guide.

I’ll also sign off my commits properly to pass the DCO check.

Once done, I’ll push the updates and request another review. Appreciate your guidance!

Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
@AradhyaTiwari10
AradhyaTiwari10 force-pushed the render-property-cdx-reproducible branch from 651d9cf to 9068fa3 Compare October 28, 2025 12:06
@AradhyaTiwari10

Copy link
Copy Markdown
Contributor Author

Hey Kindly check now i have successfully Implemented the changes needed.

Comment thread src/builders.ts Outdated
@jkowalleck jkowalleck changed the title FEAT: render property cdx:reproducible FEAT: render property cdx:reproducible Oct 28, 2025
@jkowalleck jkowalleck changed the title FEAT: render property cdx:reproducible feat: render property cdx:reproducible Oct 28, 2025
Comment thread src/builders.ts Outdated
Comment thread src/builders.ts Outdated
…etadata

Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Comment thread src/builders.ts Outdated
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
…roducible condition

Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Comment thread src/builders.ts Outdated
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
@AradhyaTiwari10

Copy link
Copy Markdown
Contributor Author

@jkowalleck
Thanks a lot for the review and approval!
Just checking if there’s anything else needed from my side before it can be merged.

@jkowalleck
jkowalleck merged commit 298587a into CycloneDX:main Oct 29, 2025
23 checks passed
@jkowalleck

Copy link
Copy Markdown
Member

thank you for the contribution.

@jkowalleck

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FEAT: render property cdx:reproducible

2 participants