feat: render property cdx:reproducible - #1373
Conversation
|
Note: Some integration tests may fail due to snapshot mismatches from previous versions. The functionality itself works as expected. please create the snapshots as needed. |
|
your PR does not follow our contribution guidelines. here is how to fix this: https://github.com/CycloneDX/cyclonedx-node-npm/pull/1373/checks?check_run_id=53847302694 |
|
Thanks for the detailed feedback, @jkowalleck I’ll remove the unintended bom.json file. I’ll restore the src/builders.ts content that deletion was accidental. I’ll re run the integration tests with CNPM_TEST_UPDATE_SNAPSHOTS=1 to regenerate snapshots as per the contribution guide. I’ll also sign off my commits properly to pass the DCO check. Once done, I’ll push the updates and request another review. Appreciate your guidance! |
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
651d9cf to
9068fa3
Compare
|
Hey Kindly check now i have successfully Implemented the changes needed. |
cdx:reproducible
cdx:reproduciblecdx:reproducible
…etadata Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
…roducible condition Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
|
@jkowalleck |
|
thank you for the contribution. |
|
feature was released via https://github.com/CycloneDX/cyclonedx-node-npm/releases/tag/v4.1.0 |
Adds a cdx:reproducible property under metadata.properties to indicate whether the SBOM was built in reproducible mode.
This fulfills issue #1054 (Hacktoberfest).
I tested it locally through:
npx cyclonedx-npm --output bom.jsonOutput was:
Note: Some integration tests may fail due to snapshot mismatches from previous versions. The functionality itself works as expected.