Skip to content

feat: prefer trusted data, fix external deps edge-cases - #1307

Merged
jkowalleck merged 34 commits into
mainfrom
feat/revisit-component-gathering
Jun 23, 2025
Merged

feat: prefer trusted data, fix external deps edge-cases#1307
jkowalleck merged 34 commits into
mainfrom
feat/revisit-component-gathering

Conversation

@jkowalleck

@jkowalleck jkowalleck commented Jun 17, 2025

Copy link
Copy Markdown
Member

the revisit's goal:

  • prefer trusted data from the npm-ls. this might lead to changes in the output.
  • properly handle external packages edge-cases. this might lead to changes in the output.
  • try to simplify the implementation's design
  • have consistent tests over all systems

closes #1304


  • BREAKING Changes
    • SBOM results might have slightly changed
  • Fixed
    • External dependency edge-cases are now properly nested
  • Changed
    • SBOM result's purl is prefixed with parent-component's one to ensure uniqueness
    • Uses only trusted data from npm-ls internally
      No changes in data quality are expected.

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the breaking-change breacking change. causes a new major version. label Jun 18, 2025
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Comment thread tests/_data/sbom_dummy-results/bare/with-prepared.snap.json Outdated
Comment thread tests/_data/sbom_dummy-results/bare/with-prepared.snap.json Outdated
Comment thread tests/_data/sbom_dummy-results/bare/with-prepared.snap.json Outdated
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
jkowalleck marked this pull request as ready for review June 19, 2025 08:55
@jkowalleck
jkowalleck requested a review from a team as a code owner June 19, 2025 08:55
@codacy-production

codacy-production Bot commented Jun 19, 2025

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+3.93% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2e4686b) 4104 3461 84.33%
Head commit (fc975bf) 4224 (+120) 3728 (+267) 88.26% (+3.93%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1307) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title [WIP] refactor: revisit component gathering refactor: revisit component gathering Jun 19, 2025
@jkowalleck jkowalleck changed the title refactor: revisit component gathering feat: use trusted data only, fix external deps edge-cases Jun 19, 2025
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added bug Something isn't working enhancement New feature or request QA labels Jun 19, 2025
@jkowalleck jkowalleck changed the title feat: use trusted data only, fix external deps edge-cases feat: prefer trusted data, fix external deps edge-cases Jun 19, 2025
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change breacking change. causes a new major version. bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant