Skip to content

chore(deps): no longer depend on dependency packageurl-js #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkowalleck merged 1 commit into from
Nov 20, 2024
Merged

chore(deps): no longer depend on dependency packageurl-js #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@ All notable changes to this project will be documented in this file.

<!-- unreleased changes go here -->

* Dependencies
* No longer depend on `packageurlk-js` (via [#1237])
* Build
* Use _TypeScript_ `v5.6.2` now, was `v5.5.3` (via [#1209], [#1218])

[#1209]: https://github.com/CycloneDX/cyclonedx-node-npm/pull/1209
[#1218]: https://github.com/CycloneDX/cyclonedx-node-npm/pull/1218
[#1237]: https://github.com/CycloneDX/cyclonedx-node-npm/pull/1237

## 1.19.3 -- 2024-07-15

Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
"@cyclonedx/cyclonedx-library": "^6.11.0",
"commander": "^10.0.0",
"normalize-package-data": "^3||^4||^5||^6",
"packageurl-js": "^1.2.1",
"xmlbuilder2": "^3.0.2"
},
"devDependencies": {
Expand Down
3 changes: 1 addition & 2 deletions src/builders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ Copyright (c) OWASP Foundation. All Rights Reserved.
import { type Builders, Enums, type Factories, Models, Utils } from '@cyclonedx/cyclonedx-library'
import { existsSync } from 'fs'
import * as normalizePackageData from 'normalize-package-data'
import { type PackageURL } from 'packageurl-js'
import * as path from 'path'

import { isString, loadJsonFile, tryRemoveSecretsFromUrl } from './_helpers'
Expand Down Expand Up @@ -544,7 +543,7 @@ export class BomBuilder {
return component
}

private makePurl (component: Models.Component): PackageURL | undefined {
private makePurl (component: Models.Component): ReturnType<BomBuilder['purlFactory']['makeFromComponent']> {
const purl = this.purlFactory.makeFromComponent(component, this.reproducible)
if (purl === undefined) {
return undefined
Expand Down