Skip to content

tests: regression for engine/npm support #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkowalleck merged 3 commits into from
Sep 18, 2023
Merged

tests: regression for engine/npm support #1108

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
991ecab
regression test for #1107
jkowalleck Sep 18, 2023
e8a0c63
try narrow down prod-envs
jkowalleck Sep 18, 2023
30d1d06
remove some npde versions for dogfooding tests
jkowalleck Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
run: |
set -ex
## dont install all the dev-packages, especially since some are not runnable on node 14.0.0
npm i --ignore-scripts --omit=dev --only=prod --loglevel=silly
npm i --ignore-scripts --omit=dev --only=prod --production --loglevel=silly
## rebuild deps for which scripts were ignored, or partially installed - since "ignore-scripts" was used
npm rebuild --loglevel=silly libxmljs2 || npm uninstall --no-save libxmljs2
## install the needed dev-deps
Expand Down Expand Up @@ -151,13 +151,15 @@ jobs:
node-version: '^18'
- npm-version: '^8'
## "node": "^12.13.0 || ^14.15.0 || >=16"
node-version: '^16'
# node-version: '^16' ## cannot pin due to https://github.com/npm/cli/issues/6743
- npm-version: '^7'
## "node": ">=10"
node-version: '^14'
# node-version: '^14' ## cannot pin due to https://github.com/npm/cli/issues/6743
- npm-version: '^6'
## "node": "6 >=6.2.0 || 8 || >=9.3.0"
node-version: '^14'
# node-version: '^14' ## cannot pin due to https://github.com/npm/cli/issues/6743
env:
npm_config_engine_strict: true

@jkowalleck jkowalleck Sep 18, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ this is the relevant change

timeout-minutes: 10
steps:
- name: Checkout
Expand All @@ -178,7 +180,7 @@ jobs:
shell: bash
run: |
set -ex
npm i --ignore-scripts --omit=dev --only=prod --loglevel=silly
npm i --ignore-scripts --omit=dev --only=prod --production --loglevel=silly
## rebuild deps for which scripts were ignored, or partially installed - since "ignore-scripts" was used
npm rebuild --loglevel=silly libxmljs2 || npm uninstall --no-save libxmljs2
- name: fetch build artifact
Expand Down