Skip to content

fix: explicit allow engine npm@10 - #1107

Merged
jkowalleck merged 2 commits into
CycloneDX:mainfrom
joonamo:npm-10-engines
Sep 18, 2023
Merged

fix: explicit allow engine npm@10#1107
jkowalleck merged 2 commits into
CycloneDX:mainfrom
joonamo:npm-10-engines

Conversation

@joonamo

@joonamo joonamo commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

#974 introduced support for npm 10, but package.json engines field was left with just npm 6 - 9. This tiny PR updates the engines field to npm 6 - 10, so npm 10 can be used without --ignore-engines flag.

This PR doesn't introduce any functional changes.

Signed-off-by: Joona Heinikoski <joona.heinikoski@reaktor.com>
@joonamo
joonamo requested a review from a team as a code owner September 18, 2023 07:29
@joonamo joonamo mentioned this pull request Sep 18, 2023
@jkowalleck jkowalleck changed the title Allow node 10 in package.json engines fix: allow engine npm@10 Sep 18, 2023
@jkowalleck jkowalleck changed the title fix: allow engine npm@10 fix: explicit allow engine npm@10 Sep 18, 2023
@jkowalleck

Copy link
Copy Markdown
Member

thanks for the quick fix 👍

will have it released as a bugfix, as this was expected to be done already by #973//#974
(i must have rolled it back after my local tests and forgot about it.)

jkowalleck added a commit that referenced this pull request Sep 18, 2023
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck

jkowalleck commented Sep 18, 2023

Copy link
Copy Markdown
Member

regression tests should be added via #1108
were merged in here via 10177f3

@jkowalleck
jkowalleck merged commit 841527a into CycloneDX:main Sep 18, 2023
@joonamo
joonamo deleted the npm-10-engines branch September 18, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants