feat: Support X# Project files (#895) #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Volkmar Rigo <[email protected]>
mtsfoni
approved these changes
Aug 4, 2024
|
Seems there was a weird bug in the pipeline, I think I fixed it. Could you rebase your PR? |
|
Anything else I can do to get this RR merged? I'm not very experienced in making PR's to open source projects, so I don't know if I missed something. |
|
No, this is alright. The only thing you missed is how strained personal resources in open source projects are. I merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volkmar Rigo [email protected]