-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: demo extractor updated yara #62
fix: demo extractor updated yara #62
Conversation
unfortunately I can't see why the tests failed - is it related to the use of the |
The tests failed on Py3.8 and Py3.9.
Re-Running the tests results in some runs passing and others failing. |
ps: not related to the use of I get the same results running the tests via tox, and also after converting to purely use |
We could convert those into sets in the test files, I believe we do that as a workaround in the AL pytests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forcing sorted output in the demo extractor would make testing easier.
Enable reliable testing.
This PR fixes the demo complex extractor for yara v4.3.0 compatibility and adds a test case so we can pick up the failure in the future.
Fixes #56