Code refactor #15
Code refactor #15
Conversation
|
@RamolaWeb Would you like to review this PR? |
| '<link rel="stylesheet" href="style.min.css" type="text/css" media="all" />' | ||
| '<script src="https://cdn.rawgit.com/google/code-prettify/master/loader/run_prettify.js"></script>' | ||
| '</head><body>' | ||
| ) |
There was a problem hiding this comment.
The Closing Brackets Does not matching any visual indentation.
| 4: 'python', | ||
| 5: 'fundamentals-of-algorithms', | ||
| 6: 'data-structures' | ||
| } |
There was a problem hiding this comment.
The Closing Brackets does not match any Visual Indentation
There was a problem hiding this comment.
Can you please explain this?
There was a problem hiding this comment.
@CuriousLearner I have use a code Linter to lint the code and at this line it was saying that The Closing Brackets does not match any Visual Indentation. That means the closing brackets of the code are not indented properly to match the starting brackets
There was a problem hiding this comment.
I guess both are valid syntax like
a = {
'some_key': 'some_value'
}
and
a = {
'some_key': 'some_value'
}
There was a problem hiding this comment.
@CuriousLearner Ok Then I think the code is clean now
|
@RamolaWeb Can you try running the script again and verify here if everything looks good? Then we can merge this. |
|
Hi @RamolaWeb Please let me know here once you verify these changes, and I'll merge them in! Thanks! |
|
@CuriousLearner Everything look good , I have Tested the Code till here and everything look correct . The linking in the pdf is not working but it may be the problem of the library. I think we can merge here to add new feature to it. |
|
@RamolaWeb Yes, that's an issue as we've seen on the repo of Thanks for the help! |
This PR aims at cleaning the code and create a proper directory structure for maintenance.